show warning for old livemode values #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcheung-stripe
approved these changes
Aug 2, 2022
| (!) Livemode value found for the field '` + LiveModeAPIKeyName + `' in your config file. | ||
| Livemode values from the config file will be redacted and will not be used.`)) | ||
|
|
||
| p.WriteConfigField(LiveModeAPIKeyName, RedactAPIKey(key)) |
There was a problem hiding this comment.
Should we redact LiveModePubKeyName too?
There was a problem hiding this comment.
i did that at first but tomer said we should leave out publishable key since its public facing, which makes sense
| @@ -139,7 +139,8 @@ func (p *Profile) GetAPIKey(livemode bool) (string, error) { | |||
| key = viper.GetString(p.GetConfigField(TestModeAPIKeyName)) | |||
| } | |||
| } else { | |||
| key, err = p.RetrieveLivemodeValue(LiveModeAPIKeyName) | |||
| p.redactAllLivemodeValues() | |||
There was a problem hiding this comment.
Would the values already be redacted by this point? Is this call defensive?
There was a problem hiding this comment.
yes its a defensive check in case user manually edits the config tom file again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @vcheung-stripe
cc @stripe/developer-products
Summary