Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: exception for ppc64 and s390x to not run UI tests #3962

Merged
merged 1 commit into from
Aug 8, 2018
Merged

add: exception for ppc64 and s390x to not run UI tests #3962

merged 1 commit into from
Aug 8, 2018

Conversation

tomleah
Copy link
Contributor

@tomleah tomleah commented Aug 8, 2018

Description

PhantomJs does not support ppc64 and s390x machines.
This addition stops PhantomJs tests from running on these unsupported architectures, allowing the test suite to pass.

Checklist

@slnode
Copy link

slnode commented Aug 8, 2018

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@virkt25
Copy link
Contributor

virkt25 commented Aug 8, 2018

Ok to test

@virkt25 virkt25 self-assigned this Aug 8, 2018
@virkt25 virkt25 merged commit 0dac936 into strongloop:master Aug 8, 2018
@virkt25
Copy link
Contributor

virkt25 commented Aug 8, 2018

@tomleah Your PR has landed! Thanks for the contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants