Add CompositeAggregation#missingBucket #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-suhas
requested changes
Jan 23, 2020
There was a problem hiding this comment.
Hey @exoego, thanks for the PR. Apart from the review comments, could you also add a test alongside and similar to 👇
Thanks!
| @@ -105,6 +105,17 @@ class ValuesSourceBase { | |||
| return this; | |||
| } | |||
|
|
|||
| /** | |||
| * Specifies to include documents without a value for a given source in the | |||
There was a problem hiding this comment.
Change to Specifies whether to include documents without a value for a given source in the response. Defaults to false (not included).. Could you also wrap the comment at 80 characters?
There was a problem hiding this comment.
Addressed in 96fc517
src/aggregations/bucket-aggregations/composite-agg-values-sources/values-source-base.js
Show resolved
Hide resolved
src/index.d.ts
Outdated
| @@ -4655,10 +4655,22 @@ declare namespace esb { | |||
| * Missing specifies the value to use when the source finds a missing value | |||
| * in a document. | |||
| * | |||
| * Note: The `missing` option of the composite aggregation is deprecated in | |||
| * [Elastticsearch v6.0](https://www.elastic.co/guide/en/elasticsearch/reference/6.8/breaking-changes-6.0.html#_literal_missing_literal_is_deprecated_in_the_literal_composite_literal_aggregation), | |||
There was a problem hiding this comment.
Suggested change
| * [Elastticsearch v6.0](https://www.elastic.co/guide/en/elasticsearch/reference/6.8/breaking-changes-6.0.html#_literal_missing_literal_is_deprecated_in_the_literal_composite_literal_aggregation), | |
| * [Elasticsearch v6](https://www.elastic.co/guide/en/elasticsearch/reference/6.8/breaking-changes-6.0.html#_literal_missing_literal_is_deprecated_in_the_literal_composite_literal_aggregation), |
There was a problem hiding this comment.
Addressed in 96fc517
src/aggregations/bucket-aggregations/composite-agg-values-sources/values-source-base.js
Show resolved
Hide resolved
src/index.d.ts
Outdated
Comment on lines
4658
to
4659
| * Note: The `missing` option of the composite aggregation is deprecated in | ||
| * [Elastticsearch v6.0](https://www.elastic.co/guide/en/elasticsearch/reference/6.8/breaking-changes-6.0.html#_literal_missing_literal_is_deprecated_in_the_literal_composite_literal_aggregation), |
There was a problem hiding this comment.
Could you add this note here as well 👇
There was a problem hiding this comment.
Addressed in 96fc517
added 2 commits
January 23, 2020 16:41
exoego
force-pushed
the
composite-missing-bucket
branch
from
2db2f9d to
849225a
Compare
exoego
commented
Jan 23, 2020
test/aggregations-test/composite-agg-values-sources-test/terms-values-source.test.js
Outdated
Show resolved
Hide resolved
|
Thank you @exoego! Changes have been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of breking change in ES v6.0.
This PR adds CompositeAggregation#missingBucket.