SP fixes for sync-20250309

[devtekve]

Summary by Sourcery

This pull request includes several fixes and improvements. It addresses an argument mismatch in a function call, adds a new test case for MADS heartbeat engagement, updates CAN message creation, increases timeout values for mutation tests, and updates the safety helpers.

Tests:

• Adds a new test case for MADS heartbeat engaged check behavior, ensuring that the system correctly handles the engagement and disengagement of the heartbeat based on boolean values.
• Adds a test to toggle MADS with the MADS button.
• Adds tests for longitudinal control for ICE, hybrid, and EV cars with LFA steering, covering various scenarios and ensuring proper functionality across different vehicle types.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request includes several fixes and improvements. It adds a test case for the MADS heartbeat check, modifies the _accel_msg and _tx_acc_state_msg functions to use the PT_BUS constant, increases the timeout for safety mutation tests, adds an abstract method _tx_acc_state_msg, adds a function prototype for mads_heartbeat_engaged_check, and updates the get_params_for_docs function call.

Sequence diagram for get_params_for_docs function call

sequenceDiagram
  participant platform
  participant get_params_for_docs

  platform->>+get_params_for_docs: get_params_for_docs(platform)
  get_params_for_docs-->>-platform: CP

Loading

File-Level Changes

Change	Details	Files
Added a test case to verify the behavior of the MADS (Manually Activated Driver Steering) heartbeat engaged check.	Added a new test function test_heartbeat_engaged_mads_check. The test function checks if the controls_allowed_lat state remains engaged or disengages based on the heartbeat state. The test function calls mads_heartbeat_engaged_check multiple times to ensure the engagement state is correctly updated.	opendbc/safety/tests/mads_common.py
Modified the _accel_msg and _tx_acc_state_msg functions to use the PT_BUS constant instead of hardcoded bus numbers.	Replaced the literal 1 with self.PT_BUS in the _accel_msg function. Replaced the literal 0 with self.PT_BUS in the _tx_acc_state_msg function.	opendbc/safety/tests/test_hyundai_canfd.py opendbc/safety/tests/test_hyundai_can.py
Increased the timeout for safety mutation tests in the GitHub Actions workflow.	Increased the timeout-minutes for the mutation job from 20 to 60. Increased the timeout-minutes for the Run mutation tests step from 10 to 60.	.github/workflows/tests.yml
Added an abstract method _tx_acc_state_msg to the hyundai_common.py file.	Added _tx_acc_state_msg to the HyundaiCommon class.	opendbc/safety/tests/hyundai_common.py
Added a function prototype for mads_heartbeat_engaged_check to the PandaSafety protocol.	Added void mads_heartbeat_engaged_check(void); to the setup_safety_helpers function. Added def mads_heartbeat_engaged_check(self) -> None: ... to the PandaSafety protocol.	opendbc/safety/tests/libsafety/safety_helpers.py
Updated the get_params_for_docs function call by removing the redundant 'model' parameter.	Removed the model parameter from the get_params_for_docs function call.	opendbc/sunnypilot/car/platform_list.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[devtekve]

Note: The safety mutation failure is expected
commaai#1852 (comment)

[sourcery-ai]

We've reviewed this pull request using the Sourcery rules engine.