feat: add support for download options #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MagnusHJensen
force-pushed
the
feat/add-download-options-support
branch
from
b38c2cd to
ddd0a58
Compare
MagnusHJensen
force-pushed
the
feat/add-download-options-support
branch
from
ddd0a58 to
06dd7f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adds new support for download options to allow
GetPublicUrl, ´CreateSignedUrlandCreateSignedUrls` to support generating a url which contains download options.What is the current behavior?
No support.
What is the new behavior?
Support for it, by adding a nullable options field to those method, to avoid breaking changes.
My first thought was to include a boolean and a string value, but it's just a weird way to do it, so I instead relied solely on the
FileNameattribute to check if we should set download - where""defaults to=trueaka. original file names as they are in the bucket.If this approach is not preferred in it's current form another way could be to add a virtual setter, for a boolean field that sets the FileName field behind the scenes, so we still only rely on one field?
Additional context
closes: #17