-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stale bot #131
Add stale bot #131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @juancarlospaco - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
- uses: actions/stale@v9 | ||
with: | ||
days-before-pr-stale: 365 | ||
days-before-pr-close: -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_refinement): Setting 'days-before-pr-close' to -1 may prevent PRs from ever being closed.
Consider setting a positive number of days or a clear policy for closing stale PRs to ensure the repository remains clean and manageable.
days-before-pr-close: -1 | |
days-before-pr-close: 30 |
days-before-pr-stale: 365 | ||
days-before-pr-close: -1 | ||
days-before-issue-stale: 365 | ||
days-before-issue-close: -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code_refinement): Setting 'days-before-issue-close' to -1 may prevent issues from ever being closed.
It's generally a good practice to have a finite closure time for issues to keep the issue tracker clean and focused.
days-before-issue-close: -1 | |
days-before-issue-close: 30 |
name: Stale Issues & PRs | ||
|
||
on: | ||
schedule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): The cron schedule is set to run daily at midnight, consider less frequent checks if activity is low.
Running this action daily might be more frequent than necessary, which could lead to unnecessary usage of GitHub Actions minutes. Adjusting this to a less frequent schedule could be more efficient.
schedule: | |
schedule: | |
- cron: '0 0 * * 0' |
What kind of change does this PR introduce?
Additional context