Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stale bot #131

Merged
merged 1 commit into from
May 1, 2024
Merged

Add stale bot #131

merged 1 commit into from
May 1, 2024

Conversation

juancarlospaco
Copy link
Contributor

What kind of change does this PR introduce?

  • Add stale bot to mark issues and PRs as Stale after a long period of inactivity.
  • Currently, it does NOT close issues automatically, but it can do so if wanted.
  • Same yaml as Add stale bot supabase-py#774

Additional context

@juancarlospaco juancarlospaco requested a review from a team as a code owner April 29, 2024 23:32
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @juancarlospaco - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

- uses: actions/stale@v9
with:
days-before-pr-stale: 365
days-before-pr-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Setting 'days-before-pr-close' to -1 may prevent PRs from ever being closed.

Consider setting a positive number of days or a clear policy for closing stale PRs to ensure the repository remains clean and manageable.

Suggested change
days-before-pr-close: -1
days-before-pr-close: 30

days-before-pr-stale: 365
days-before-pr-close: -1
days-before-issue-stale: 365
days-before-issue-close: -1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (code_refinement): Setting 'days-before-issue-close' to -1 may prevent issues from ever being closed.

It's generally a good practice to have a finite closure time for issues to keep the issue tracker clean and focused.

Suggested change
days-before-issue-close: -1
days-before-issue-close: 30

name: Stale Issues & PRs

on:
schedule:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (performance): The cron schedule is set to run daily at midnight, consider less frequent checks if activity is low.

Running this action daily might be more frequent than necessary, which could lead to unnecessary usage of GitHub Actions minutes. Adjusting this to a less frequent schedule could be more efficient.

Suggested change
schedule:
schedule:
- cron: '0 0 * * 0'

@J0 J0 merged commit 5d1906a into supabase:master May 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants