-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update websockets #19
Conversation
Cool, any ETA on fixing this? |
I would also use |
👍🏻 will do |
@anand2312 perfect! Whenever you get the todos done, I'll review de PR 🙂 |
🤔 I don't think the TODOS will fit into the scope of this PR itself, they'd rather be separate PRs.
I added them both so that they aren't missed when new changes are being made, but I'm not free to make those changes myself right now. Perhaps I can leave issues opened. |
It was more that I was only aiming to fix the issue at hand (upgrade websockets to a version that patches the security issue) and ended up seeing more issues in the codebase 🙂 |
Ohh I see! I didn't understand you well. Alright 😄 |
ping @J0 and @aantn in case you didn't understand @anand2312 well either. |
Thank you guys. I appreciate the effort. Is there any ETA for a release on pypi including this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@aantn we will publish a new version within a few hours(after work). Thanks for your patience and understanding! |
New release published :) Feel free to let us know if you run into any issues |
Resolves supabase/supabase-py#71 by updating to websockets v9.1
Other minor changes:
Fixes some incorrect type annotations.
I have also added some TODO comments to:
asyncio.get_event_loop
toasyncio.get_running_loop
wherever we use it: get_event_loop is deprecated since Python 3.10except Exception
andprint