-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deps): bump websockets from 13.1 to 14.2 #261
Conversation
1f9f82c
to
bca81ce
Compare
@dependabot rebase |
bca81ce
to
118dbcb
Compare
@dependabot rebase |
Bumps [websockets](https://github.com/python-websockets/websockets) from 13.1 to 14.2. - [Release notes](https://github.com/python-websockets/websockets/releases) - [Commits](python-websockets/websockets@13.1...14.2) --- updated-dependencies: - dependency-name: websockets dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
118dbcb
to
0fd2f0b
Compare
The test here keeps on failing so I think something might have changed in this major version bump of websockets. We should investigate this first to see if there are any breaking changes that will affect this library. |
There was a slight change in the interface that is a breaking change between 13.x and 14.x versions. Not familiar with realtime's codebase, but for my own projects only small changes were required to migrate. https://websockets.readthedocs.io/en/stable/howto/upgrade.html 14.0 came out back in November and since then some libraries have already switched to 14.x. Since supabase-py depends on realtime, this has introduced a dependency conflict for me. |
Pull Request Test Coverage Report for Build 13031947177Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@juancarlospaco help, coveralls is fighting with me. The tests pass but coveralls is stopping the tasks from completing. I think we should move coveralls to its own step and not bundle it with the test steps. |
Ok, will check it!; Sorry I was expecting it to be more reliable by default and not halt the build... |
@juancarlospaco I got it fixed, there is a parallel flag available that we should probably use in all the other repos. I've added it to the coveralls config in the ci.yml for this repo already. |
Bumps websockets from 13.1 to 14.2.
Release notes
Sourced from websockets's releases.
Commits
624a36c
Release version 14.2.c8242bb
Add changelog for #1566.17e309a
Mention another symptom in the changelog.7de24bd
Improve previous commit.7e617b2
Add regex support inServerProtocol(origins=...)
.613f3f0
Prevent close() from blocking when reading is paused.e7a098e
Prevent AssertionError in the recv_events thread.031ec31
Prevent close() from blocking when reading is paused.6317c00
Clarify behavior ofrecv(timeout=0)
behavior.b1e88fc
Bump pypa/cibuildwheel from 2.21.3 to 2.22.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)