Remove dataclasses dependency
#48
Conversation
|
@lionellloh tagging you as you seem to have the most commits to the project in the past :) I am afraid I cannot assign anyone as a reviewer to this PR - do you mind advising what will be the right course of action to get this merged? Also please let me know if there is anything else I need to do in terms of structuring this PR. It is an extremely minor change, so I didn't even create a new issue for this as there is an existing one discussing this problem (#22 ). |
|
@J0 Maybe you can help with the above? I've seen your contributions in |
|
We'll publish a new version end of week together with some changes but feel free to let us know if you need it sooner |
|
Thanks for merging, and no rush on my side as I have a workaround now in place. |
- Dataclasses is no longer needed. It is a dependency needed only for Python < 3.7. Realtime, however requires Python >= 3.7, and so this dep isn't needed. - Already removed in realtime supabase/realtime-py#48 - Fixes supabase#33 (comment) This issue comes up when using this library in AWS Lambda with serverless framework plugin serverless-python-requirements and this lock file makes it hard to deploy to Lambda with environments Python >= 3.7.
- Dataclasses is no longer needed. It is a dependency needed only for Python < 3.7. Realtime, however requires Python >= 3.7, and so this dep isn't needed. - Already removed in realtime supabase/realtime-py#48 - Fixes supabase/supabase-py#33 (comment) This issue comes up when using this library in AWS Lambda with serverless framework plugin serverless-python-requirements and this lock file makes it hard to deploy to Lambda with environments Python >= 3.7.
- Dataclasses is no longer needed. It is a dependency needed only for Python < 3.7. Realtime, however requires Python >= 3.7, and so this dep isn't needed. - Already removed in realtime supabase/realtime-py#48 - Fixes supabase/supabase-py#33 (comment) This issue comes up when using this library in AWS Lambda with serverless framework plugin serverless-python-requirements and this lock file makes it hard to deploy to Lambda with environments Python >= 3.7.
What kind of change does this PR introduce?
This PR removes the
dataclassesdependency, which is not needed as the library is currently targeting Python 3.7+ (according to thepyproject.toml). From Python 3.7 onwardsdataclassesis a part of Python standard library (https://docs.python.org/3/whatsnew/3.7.html).Current behaviour (
dataclassesbeing a declared dependency) leads to bugs and crashes when using more modern versions of Python, as discussed in the following issue: #22Closes #22