Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix resolution strategy selection #297

Merged
merged 2 commits into from
Mar 8, 2025
Merged

fix: fix resolution strategy selection #297

merged 2 commits into from
Mar 8, 2025

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Mar 8, 2025 •
edited
Loading

Changes:

  1. Make the local environment variables PYTHON_VERSION and RESOLUTION_STRATEGY available in the container for the postStartCommand.
  2. Set Poe the Poet's executor type to simple. Otherwise, it seemingly reapplies uv sync before running a task (related: Implemented first version of uv executor nat-n/poethepoet#271).

@lsorber lsorber requested a review from sinopeus March 8, 2025 16:11
@lsorber lsorber self-assigned this Mar 8, 2025
sinopeus
sinopeus approved these changes Mar 8, 2025
View reviewed changes
Copy link
Collaborator

@sinopeus sinopeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sinopeus sinopeus merged commit 23b89ad into main Mar 8, 2025
20 checks passed
@lsorber lsorber deleted the ls-resolution branch March 8, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinopeus sinopeus sinopeus approved these changes

Assignees

@lsorber lsorber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsorber @sinopeus