Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify publishing to PyPI from GitHub Actions #300

Merged
merged 1 commit into from
Mar 12, 2025
Merged

feat: simplify publishing to PyPI from GitHub Actions #300

merged 1 commit into from
Mar 12, 2025
+5 −4

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Mar 11, 2025 •
edited
Loading

Changes:

  1. Simplify the publishing workflow to use the new Trusted Publisher feature. This means you no longer need to create or set a publish token to publish from GitHub Actions.
  2. Fix the runs-on field and instead install uv, which is not a valid value and caused the release of Conformal Tights to hang.
  3. Simplify docker-compose.yml by removing the UV_PUBLISH_TOKEN unless the project is configured to publish a package without GitHub Actions.

@lsorber lsorber requested a review from sinopeus March 11, 2025 16:34
@lsorber lsorber self-assigned this Mar 11, 2025
sinopeus
sinopeus approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@sinopeus sinopeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change and TIL about Trusted Publisher! LGTM

@sinopeus sinopeus merged commit a7b9319 into main Mar 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinopeus sinopeus sinopeus approved these changes

Assignees

@lsorber lsorber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsorber @sinopeus