Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing permission for trusted publishing #301

Merged
merged 1 commit into from
Mar 12, 2025
Merged

fix: add missing permission for trusted publishing #301

merged 1 commit into from
Mar 12, 2025
+3 −4

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Mar 12, 2025

Changes:

  1. Add missing id-token: write permission that is necessary for Trusted Publishing [1].
  2. Remove the UV_PUBLISH_TOKEN altogether since Trusted Publishing is available for several sources, including GitLab.

[1] https://docs.pypi.org/trusted-publishers/using-a-publisher/

@lsorber lsorber requested a review from sinopeus March 12, 2025 13:00
@lsorber lsorber self-assigned this Mar 12, 2025
sinopeus
sinopeus approved these changes Mar 12, 2025
View reviewed changes
Copy link
Collaborator

@sinopeus sinopeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sinopeus sinopeus merged commit e8697ed into main Mar 12, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinopeus sinopeus sinopeus approved these changes

Assignees

@lsorber lsorber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsorber @sinopeus