Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add idPrefix to render #15428

Merged
merged 26 commits into from
Mar 4, 2025
Merged

feat: add idPrefix to render #15428

merged 26 commits into from
Mar 4, 2025

Conversation

Rich-Harris
Copy link
Member

Alternative to #15403. Rather than adding idPrefix to mount and hydrate, it makes client-side ID generation global via the window.__svelte object. This is more reliable than expecting people to deconflict in the rare cases that multiple Svelte runtimes exist on the page.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 57b4d3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

github-actions bot commented Mar 4, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15428

@dummdidumm dummdidumm merged commit b82692a into main Mar 4, 2025
10 checks passed
@dummdidumm dummdidumm deleted the id-prefix branch March 4, 2025 10:49
@github-actions github-actions bot mentioned this pull request Mar 4, 2025
@Hugos68
Copy link
Contributor

Hugos68 commented Mar 4, 2025

This is awesome! @Rich-Harris, @paoloricciuti and @dummdidumm thanks for helping me with this and coming up with a solution quickly. I can now submit a PR to Astro to include it in their sveltejs integration so that islands will have unique ID's!

@Rich-Harris
Copy link
Member Author

Thank you @Hugos68!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants