-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hasUnscopedGlobalCss
to compile
metadata
#15450
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: ee4869f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
packages/svelte/src/compiler/phases/2-analyze/css/css-analyze.js
Outdated
Show resolved
Hide resolved
This feels very specific to Given that, do we really want to add it here? It adds more code to If the answer is 'yes' then I'd at least suggest changing the API so that it's |
Initially I added it there but it felt a bit wrong since we already have the metadata object. But if we want to move it it's fine too. For the question of "should we do it" this could save one walk since we are already walking to analyze css but effectively does feels a bit specific. At the end of the day the PR it's here, up to discuss if we want to do it, otherwise we can close it 😌 |
Closes #15449
From my tests it should be basically it (it's missing the
--global
keyframes but i'm gonna add them now) but please try to break it.No test because we don't have a test suite for the compiled output...should we add it?
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint