-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support variables in auth urls #5913
Merged
tim-lai
merged 7 commits into
swagger-api:master
from
pseudo-su:fix/allow-variables-in-auth-urls
Jun 10, 2020
Merged
fix: support variables in auth urls #5913
tim-lai
merged 7 commits into
swagger-api:master
from
pseudo-su:fix/allow-variables-in-auth-urls
Jun 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f973b2
to
873ae6c
Compare
3bae914
to
86b373a
Compare
vandernorth
approved these changes
Apr 10, 2020
bartlaarhoven
approved these changes
Apr 10, 2020
vandernorth
approved these changes
Apr 14, 2020
@pseudo-su Merged! Thanks for the contribution! |
mattyb678
pushed a commit
to mattyb678/swagger-ui
that referenced
this pull request
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when using variables in your server definitions the auth plugin doesn't interpolate the currently selected value but instead leaves url as
https://{environment}.mydomain.com/oauth2/token
.Motivation and Context
Fixes #4740
How Has This Been Tested?
npm run dev
using a spec that uses variables in it's server and checking the url that gets used when trying to trigger the auth plugin.Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests