Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support variables in auth urls #5913

Merged

Conversation

pseudo-su
Copy link
Contributor

@pseudo-su pseudo-su commented Mar 12, 2020

Description

Currently when using variables in your server definitions the auth plugin doesn't interpolate the currently selected value but instead leaves url as https://{environment}.mydomain.com/oauth2/token.

Motivation and Context

Fixes #4740

How Has This Been Tested?

npm run dev using a spec that uses variables in it's server and checking the url that gets used when trying to trigger the auth plugin.

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@pseudo-su pseudo-su force-pushed the fix/allow-variables-in-auth-urls branch 3 times, most recently from 8f973b2 to 873ae6c Compare March 12, 2020 12:32
@pseudo-su
Copy link
Contributor Author

pseudo-su commented Mar 13, 2020

@shockey @webron I'm not sure how to reach out and request someone to review this so I'm tagging you here both directly as I noticed you have activity on a recently merged PR, hope that's ok.

@pseudo-su pseudo-su force-pushed the fix/allow-variables-in-auth-urls branch from 3bae914 to 86b373a Compare April 4, 2020 03:32
@tim-lai tim-lai merged commit 21f5149 into swagger-api:master Jun 10, 2020
@tim-lai
Copy link
Contributor

tim-lai commented Jun 10, 2020

@pseudo-su Merged! Thanks for the contribution!

mattyb678 pushed a commit to mattyb678/swagger-ui that referenced this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authorize form does not replace URL variables
4 participants