Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Remove optimization for array pattern #9241

Merged
merged 3 commits into from
Jul 15, 2024
Merged

fix(es/minifier): Remove optimization for array pattern #9241

merged 3 commits into from
Jul 15, 2024

Conversation

CPunisher
Copy link
Member

@CPunisher CPunisher commented Jul 15, 2024 •
edited by kdy1
Loading

Description:

This could be an unsound optimization. The issue shows a bad case.

Related issue:

@CPunisher CPunisher requested a review from a team as a code owner July 15, 2024 05:47
@CPunisher
Copy link
Member Author

or marked as unsafe

kdy1
kdy1 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_optimization
  • swc_core

@kdy1 kdy1 added this to the Planned milestone Jul 15, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 15, 2024 06:19
@kdy1 kdy1 disabled auto-merge July 15, 2024 06:19
@kdy1 kdy1 enabled auto-merge (squash) July 15, 2024 06:19
@kdy1 kdy1 changed the title fix(es/optimization): Remove optimization for array pattern fix(es/minifier): Remove optimization for array pattern Jul 15, 2024
@kdy1 kdy1 disabled auto-merge July 15, 2024 06:22
@kdy1 kdy1 enabled auto-merge (squash) July 15, 2024 06:25
swc-bot
swc-bot reviewed Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 521161e into swc-project:main Jul 15, 2024
155 checks passed
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 15, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9241 will not alter performance

Comparing CPunisher:fix/array-pat-opt (e359fd3) with CPunisher:fix/array-pat-opt (0d5c575)

Summary

✅ 178 untouched benchmarks

@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Minifier removes empty array following empty hole at the LHS of array destructuring pattern
3 participants
@CPunisher @kdy1 @swc-bot