Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates ESLint to 8.0.0 #39

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Updates ESLint to 8.0.0 #39

merged 5 commits into from
Nov 10, 2021

Conversation

benkroeger
Copy link
Contributor

fixes #38

includes BREAKING CHANGES

  • drops node 10 support
  • drops eslint@6
  • drops eslint@7
  • drops @typescript-eslint/eslint-plugin@4

@benkroeger
removes typescript devDependency
368116d 
not used at all

Signed-off-by: Benjamin Kroeger <[email protected]>
@benkroeger
updates [email protected]
312e083 
Signed-off-by: Benjamin Kroeger <[email protected]>
@benkroeger
chore(updates devDepencencies): eslint@^8.0.0
b2c8d82 
- drops support for node 10
- adds module name mapper for jest (see eslint/eslintrc#57)

BREAKING CHANGE

Signed-off-by: Benjamin Kroeger <[email protected]>
@sweepline sweepline self-assigned this Oct 12, 2021
@sweepline
Copy link
Owner

Looks simple enough, I will test it within a couple of days and probably release it as v2.0.0

gfyoung
gfyoung reviewed Oct 12, 2021
View reviewed changes
gfyoung
gfyoung reviewed Oct 12, 2021
View reviewed changes
@gfyoung
Copy link

gfyoung commented Oct 12, 2021 •
edited
Loading

@benkroeger: Thanks for doing this! I left a couple of (very minor) comments.

@gfyoung
Copy link

gfyoung commented Oct 14, 2021 •
edited
Loading

@benkroeger: eslint just released 8.0.1, which I believe would remove the need to add jest to package.json

@benkroeger
Copy link
Contributor Author

do you guys care to release this? It's actually blocking me from upgrading my project to eslint@8

@gfyoung
Copy link

gfyoung commented Oct 24, 2021 •
edited
Loading

Looks simple enough, I will test it within a couple of days and probably release it as v2.0.0

@sweepline: Do you have an update on when you are going to review and release this? You did say that you were going to test this PR in a couple of days, but that was nearly two weeks ago. I understand that maintainers have other responsibilities beyond their projects, but making written promises and not following through can be a little problematic.

@benkroeger: I'm not sure what project you're trying to upgrade, but for some of my projects, I just installed this repository over git at 8481df4 (the last commit in your PR) so I could upgrade to eslint@8.

@sweepline sweepline merged commit 8bd226d into sweepline:master Nov 10, 2021
@sweepline
Copy link
Owner

Sorry about the wait... I've published this as v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyoung gfyoung gfyoung left review comments

Assignees

@sweepline sweepline

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESLint v8 Compatibility?
3 participants
@benkroeger @sweepline @gfyoung