Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of NIOLockedValueBox with Mutex #487

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace usage of NIOLockedValueBox with Mutex #487

wants to merge 3 commits into from

Conversation

fabianfett
Copy link
Member

No description provided.

@fabianfett fabianfett added the 🔨 semver/patch No public API change. label Feb 27, 2025
sebsto
sebsto approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@sebsto sebsto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of code, but the many tests fail now. The compiler crashes with a stack trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebsto sebsto sebsto approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabianfett @sebsto