avoid setting default values to topic configuration #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
reviewed
Aug 7, 2023
Comment on lines
+38
to
+57
| // librdkafka checks that values were modified from default (even if set to default) | ||
| // that may cause unexpected behaviour, so we should check that values are equal | ||
| var size = RDKafkaClient.stringSize | ||
| let configValue = UnsafeMutablePointer<CChar>.allocate(capacity: size) | ||
| defer { configValue.deallocate() } | ||
|
|
||
| if RD_KAFKA_CONF_OK == rd_kafka_topic_conf_get(configPointer, key, configValue, &size) { | ||
| let sizeNoNullTerm = size - 1 | ||
| let wasVal = String(unsafeUninitializedCapacity: size) { | ||
| let buf = UnsafeRawBufferPointer( | ||
| UnsafeMutableRawBufferPointer( | ||
| start: configValue, | ||
| count: sizeNoNullTerm)) | ||
| _ = $0.initialize(from: buf) | ||
| return sizeNoNullTerm | ||
| } | ||
| if wasVal == value { | ||
| return // Values are equal, avoid changing (don't mark config as modified) | ||
| } | ||
| } |
There was a problem hiding this comment.
@felixschlegel Can you take a look at this. I am not super happy with going through C here to figure this out.
Do we only have to do this for the topic configuration? If so can we just do it on the Swift side and avoid setting anything that is the default value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #106
Effectively, we should check that values are default and don't modify them. This way librdkafka would use default values from the main configuration.