Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): demo add link to beta storybook #2142

Merged
merged 12 commits into from
Nov 21, 2023

Conversation

davidritter-dotcom
Copy link
Contributor

No description provided.

@davidritter-dotcom davidritter-dotcom requested a review from a team as a code owner October 26, 2023 13:50
@davidritter-dotcom davidritter-dotcom linked an issue Oct 26, 2023 that may be closed by this pull request
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

🦋 Changeset detected

Latest commit: 704bbe6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swisspost/design-system-demo Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 26, 2023

Preview environment ready: https://preview-2142--swisspost-web-frontend.netlify.app

Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a little more rockets

@oliverschuerch oliverschuerch removed their request for review October 31, 2023 10:24
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The button is on the wrong alert.

  1. There are 325 binary files from the angular compilation checked in (packages/components-angular/.angular/...) please untrack them https://stackoverflow.com/questions/18357511/git-remove-committed-file-after-push, please ask if you need help here.

Copy link
Member

@gfellerph gfellerph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidritter-dotcom, please add a changeset for the demo "Added link to new documentation" or something along these lines.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@davidritter-dotcom davidritter-dotcom merged commit 5649040 into main Nov 21, 2023
@davidritter-dotcom davidritter-dotcom deleted the 1128-demo-add-link-to-beta-storybook branch November 21, 2023 08:18
gfellerph pushed a commit that referenced this pull request Nov 23, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @swisspost/[email protected]

### Patch Changes

- Updated icons number 2081, 2143, 2221, 2230, 2238, 2239, 2248, 2249,
2250, 2254, 2256, 2257, 2258, 2260, 2261, 2262, 2263, 2264, 2265, 2266,
2267, 2268, 2269, 2270, 2271, 2272, 2273, 2274, 2275, 2276, 2280, 2281,
2361, 2386, 2403, 2415, 2418, 2419, 2433, 2434, 2457, 2464 and 2488. (by
[@swisspost-bot](https://github.com/swisspost-bot) with
[#2284](#2284))

## @swisspost/[email protected]

### Minor Changes

- Added link to new documentation (by
[@davidritter-dotcom](https://github.com/davidritter-dotcom) with
[#2142](#2142))

- Deprecated standard HTML alerts with a close button in favor of the
`post-alert` component designed to correctly handle the dismissal
animation. (by [@b1aserlu](https://github.com/b1aserlu) with
[#2239](#2239))

### Patch Changes

-   Updated dependencies:
    -   @swisspost/[email protected]

## @swisspost/[email protected]

### Minor Changes

- Added a documentation page for the `.container` and `.container-fluid`
classes. (by [@b1aserlu](https://github.com/b1aserlu) with
[#2030](#2030))

### Patch Changes

- Removed empty p and fix CDN examples for internet-header. (by
[@imagoiq](https://github.com/imagoiq) with
[#2295](#2295))

- Added attached stories to changelog and search-icons pages to fix
"Edit this page on Github" feature. (by
[@imagoiq](https://github.com/imagoiq) with
[#2267](#2267))

-   Updated dependencies:
    -   @swisspost/[email protected]
    -   @swisspost/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Demo: Add link to beta storybook
3 participants