Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(internet-header): Fix e2e after improving the main slot #2503

Merged
merged 3 commits into from
Jan 18, 2024
Merged

fix(internet-header): Fix e2e after improving the main slot #2503

merged 3 commits into from
Jan 18, 2024

Conversation

imagoiq
Copy link
Contributor

@imagoiq imagoiq commented Jan 16, 2024

No description provided.

@imagoiq imagoiq requested a review from alizedebray January 16, 2024 10:47
@imagoiq imagoiq self-assigned this Jan 16, 2024
@imagoiq imagoiq requested a review from a team as a code owner January 16, 2024 10:47
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5facbe3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@imagoiq imagoiq removed the request for review from oliverschuerch January 16, 2024 10:47
@imagoiq imagoiq mentioned this pull request Jan 16, 2024
Merged
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jan 16, 2024 •
edited
Loading

Preview environment ready: https://preview-2503--swisspost-design-system-next.netlify.app

This was referenced Jan 16, 2024
Merged
Merged
Merged
@imagoiq imagoiq assigned alizedebray and unassigned imagoiq Jan 17, 2024
@oliverschuerch oliverschuerch mentioned this pull request Jan 18, 2024
Merged
@imagoiq imagoiq assigned imagoiq and unassigned alizedebray Jan 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@imagoiq imagoiq merged commit 6b1e740 into main Jan 18, 2024
@imagoiq imagoiq deleted the fix/e2e-internet-headers-after-improve-main-slot branch January 18, 2024 14:38
b1aserlu added a commit that referenced this pull request Jan 18, 2024
@b1aserlu @oliverschuerch
chore(styles): adds comments for deprecation (#2400)
c1bcfc5 
Also created the new issue #2399 that will remove the deprecated
classes.

Wait for #2503 to me merged.

---------

Co-authored-by: Oliver Schürch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverschuerch oliverschuerch oliverschuerch approved these changes

@alizedebray alizedebray Awaiting requested review from alizedebray

Assignees

@imagoiq imagoiq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imagoiq @swisspost-bot @oliverschuerch @alizedebray