Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): remove grid container helper classes #3527

Merged
merged 5 commits into from
Oct 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/sharp-baboons-smile.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@swisspost/design-system-styles': major
'@swisspost/design-system-documentation': minor
---

Removed deprecated grid container helper classes.
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,21 @@ export class MigrationV89Component extends LitElement {
<li><code>$line-height-huge</code></li>
</ul>
</li>
<li class="mb-3">
<p>
Removed grid container helper classes
<span class="tag tag-sm tag-danger">breaking</span>
</p>
<ul>
<li><code>.vertical-gutters</code></li>
<li><code>.row.border-gutters</code></li>
<li><code>.container-reset</code></li>
<li>
<code>.container-reset-left</code> and <code>.container-reset-right</code>
</li>
<li><code>.container-fluid-#{$breakpoint}</code></li>
</ul>
</li>
</ul>
</section>
</li>
Expand Down
82 changes: 0 additions & 82 deletions packages/styles/src/components/grid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -86,85 +86,3 @@ $gutter-x-cache: 0;
}
}
}

//the following classes are all deprecated and wil be removed in next major version

//deprecated
.vertical-gutters {
margin-bottom: grid.$grid-gutter-width * -1;

> .col,
> [class*='col-'] {
padding-bottom: grid.$grid-gutter-width;
}
}

//deprecated
// border-gutters class is used to manipulate border collapse
.row.border-gutters {
margin-right: -(commons.$border-width);
margin-bottom: -(commons.$border-width);
margin-left: 0;

> .col,
> [class*='col-'] {
padding-right: commons.$border-width;
padding-bottom: commons.$border-width;
padding-left: 0;
}
}

//deprecated
$container-cache: 0;

//deprecated
@each $breakpoint in grid.$grid-breakpoints-list {
$container-padding: map.get(grid.$grid-container-padding, $breakpoint);

// Ensure this breakpoint is only overwritten when the padding differs from the last breakpoint
@if ($container-cache != $container-padding) {
.container-reset {
@if $breakpoint == 'xs' {
margin-right: -($container-padding);
margin-left: -($container-padding);
} @else {
@include media-breakpoint-up($breakpoint) {
margin-right: -($container-padding);
margin-left: -($container-padding);
}
}
}

.container-reset-left {
@if $breakpoint== 'xs' {
margin-left: -($container-padding);
} @else {
@include media-breakpoint-up($breakpoint) {
margin-left: -($container-padding);
}
}
}

.container-reset-right {
@if $breakpoint== 'xs' {
margin-right: -($container-padding);
} @else {
@include media-breakpoint-up($breakpoint) {
margin-right: -($container-padding);
}
}
}
}

//deprecated
// Container fluid responsive needs to be written every time
.container-fluid-#{$breakpoint} {
@include media-breakpoint-only($breakpoint) {
padding-right: spacing.$spacer;
padding-left: spacing.$spacer;
}
}

//deprecated
$container-cache: $container-padding;
}
34 changes: 0 additions & 34 deletions packages/styles/src/layouts/portal/_grid.scss
Original file line number Diff line number Diff line change
Expand Up @@ -48,38 +48,4 @@
margin-left: 0;
}
}

//deprecated
.vertical-gutters {
margin-bottom: -(portal-variables.$grid-gutter-width-rg);

> .col,
> [class*='col-'] {
padding-bottom: portal-variables.$grid-gutter-width-rg;
}
}
}

//deprecated
@each $breakpoint in grid.$grid-breakpoints-list {
.container-fluid-#{$breakpoint} {
@include media-breakpoint-only($breakpoint) {
padding-right: 0;
padding-left: 0;
}
}
}

//deprecated
.container-reset-right-rg-up {
@include media-breakpoint-up(rg) {
margin-left: 0;
}
}

//deprecated
.container-reset-left-rg-up {
@include media-breakpoint-up(rg) {
margin-right: 0;
}
}