Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): tokenize the Link component styles #3590
feat(styles): tokenize the Link component styles #3590
Changes from 11 commits
3c4889c
735e706
441368e
11d7d5e
9b39668
a570b13
6990166
53ebf2a
120da6f
4466e46
7227e98
41666ee
cda79ca
52676e6
0164e0d
3f2f547
6e0d6fb
0cb8fcd
0d2a377
361f044
46f0ca1
8b5e12f
8778447
3012ac7
f9aab11
5206224
1d74aae
c079a2c
6f6100c
c917caf
cc21ca3
76eb978
2106fd1
531b418
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I get this sentence, what do you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you create a new snapshot file you also need to create the matching visual regression test here: https://github.com/swisspost/design-system/tree/main/packages/documentation/cypress/snapshots/components
*.snapshot.stories.ts
file creates this page: https://preview-3590--swisspost-design-system-next.netlify.app/iframe.html?id=snapshots--link&viewMode=storycypress/*.snapshot.ts
files uses this page to take snapshots that are compared every time we release changesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you also have to set a
data-color-mode="light"
ordata-color-mode="dark"
attribute so that the correct set of token is used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually use random UUID here, you can generate one on this website for axample: https://www.uuidgenerator.net/