fix(documentation, styles): replace broken css variables with hex values #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d754f0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
oliverschuerch
requested changes
Jan 20, 2025
I replaced the hex values with sass variables in the docs. For the components and styles I used the core tokens (for black and white) - though those are temporary and will eventually be changed later when the components are updated with the new design. |
oliverschuerch
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Please, never ever use core tokens anywhere!
For the current PR I'd like to use our existing sass color variables, wherever we already import either the core.scss or the variables/color.scss file anyway.
This will allow us to find a solution how to replace them all, when we will get rid of the sass variables in the future.
By the way, we also have some color variables for black-alpha and white-alpha colors:
https://github.com/swisspost/design-system/blob/main/packages/styles/src/variables/_color.scss
I've just added some examples in my review to show you what I mean, please update the rest accordingly...
Co-authored-by: Oliver Schürch <[email protected]>
Co-authored-by: Oliver Schürch <[email protected]>
Co-authored-by: Oliver Schürch <[email protected]>
Co-authored-by: Oliver Schürch <[email protected]>
Co-authored-by: Oliver Schürch <[email protected]>
Co-authored-by: Oliver Schürch <[email protected]>
Co-authored-by: Oliver Schürch <[email protected]>
|
oliverschuerch
approved these changes
Jan 23, 2025
leagrdv
deleted the
4406-bug-documentation-uses-non-existent-css-variables
branch
gfellerph
pushed a commit
that referenced
this pull request
Jan 27, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @swisspost/[email protected] ### Major Changes - Removed the Bootstrap `.text-bg-*` and `.link-*` helper classes. (by [@leagrdv](https://github.com/leagrdv) with [#4448](#4448)) ### Minor Changes - Add `interpolate-size: allow-keyword` for all supporting browsers, enabling transitions from and to `height: auto` (<https://developer.mozilla.org/en-US/docs/Web/CSS/interpolate-size>) (by [@gfellerph](https://github.com/gfellerph) with [#4524](#4524)) ### Patch Changes - Added media mixins to mixin/index.scss to include them in the core file. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#4351](#4351)) - Replaced previously deleted CSS variables with SASS variables. (by [@leagrdv](https://github.com/leagrdv) with [#4446](#4446)) - Refactored hover styling for links in `<post-footer>` to ensure they are underlined, aligning with the design specifications in Figma. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#4510](#4510)) - Got rid of the page wide yellow background as it can cause yellow flashing between page loads (by [@gfellerph](https://github.com/gfellerph) with [#4523](#4523)) - Fixed display of `post-megadropdown` in header. (by [@leagrdv](https://github.com/leagrdv) with [#4350](#4350)) - Corrected high contrast mode styles for `checkbox` and `radio-button`. (by [@schaertim](https://github.com/schaertim) with [#4334](#4334)) ## @swisspost/[email protected] ### Minor Changes - Added icons number 1041, 2204, 2642 and 8020. (by [@myrta2302](https://github.com/myrta2302) with [#4480](#4480)) - Added icons number 2634, 2635, 2635, 2637, 2638, 2639, 2640 and 2641. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#4481](#4481)) ### Patch Changes - Fixed UI-Icon source file names. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#4351](#4351)) ## @swisspost/[email protected] ### Patch Changes - Replaced previously deleted CSS variables with SASS variables. (by [@leagrdv](https://github.com/leagrdv) with [#4446](#4446)) - Added shadow to an optional tooltip arrow for `post-popover` component. (by [@alionazherdetska](https://github.com/alionazherdetska) with [#4441](#4441)) - Fixed `post-icon` calculated base href. (by [@leagrdv](https://github.com/leagrdv) with [#4491](#4491)) - Fixed display of `post-megadropdown` in header. (by [@leagrdv](https://github.com/leagrdv) with [#4350](#4350)) - Fixed the way the icon url gets generated in the `post-icon` component. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#4351](#4351)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Replaced previously deleted CSS variables with SASS variables. (by [@leagrdv](https://github.com/leagrdv) with [#4446](#4446)) - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Updated icon search, by implementing a paging and separating icon sets from each other. (by [@oliverschuerch](https://github.com/oliverschuerch) with [#4351](#4351)) - Added documentation for responsive design. (by [@leagrdv](https://github.com/leagrdv) with [#4452](#4452)) ### Patch Changes - Replaced previously deleted CSS variables with SASS variables. (by [@leagrdv](https://github.com/leagrdv) with [#4446](#4446)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.