Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components): expose header height to root #4925

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

myrta2302
Copy link
Contributor

@myrta2302 myrta2302 commented Mar 11, 2025

📄 Description

This PR moves the --post-header-height (visible height) and --post-header-expanded-height custom properties to the :root via the header/index.scss. All the custom properties involved and thus also exposed to the :root have also been updated with the post- prefix.
Additionaly, the scroll-padding-top property is set as the value of the (visible) header height.

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • ✔️ Existing unit tests pass locally with my changes

@myrta2302 myrta2302 linked an issue Mar 11, 2025 that may be closed by this pull request
3 tasks
Copy link

changeset-bot bot commented Mar 11, 2025

🦋 Changeset detected

Latest commit: 6d1ecec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@swisspost/design-system-documentation Patch
@swisspost/design-system-components Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-components-angular Patch
@swisspost/internet-header Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Mar 11, 2025

Related Previews

@myrta2302 myrta2302 marked this pull request as ready for review March 12, 2025 07:58
@myrta2302 myrta2302 requested review from a team as code owners March 12, 2025 07:58
@myrta2302 myrta2302 requested a review from gfellerph March 12, 2025 07:58
@myrta2302 myrta2302 requested review from alizedebray and removed request for gfellerph March 12, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose real header height on the :root
2 participants