feat: initialize icons package #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages like jest, ts-jest and node-fetch are in the process of transforming to es-modules. At the time of writing, this lead to serious compatibility issues during setup. As of January 2023, the best way forward seems to be to downgrade to v25 of these modules and evaluate updating at a later time when documentation and support for es-modules in the node ecosystem are more mature. Reference setup: https://gist.github.com/iRoachie/3f9b4855ee4891050c8e900ed9953773
🦋 Changeset detectedLatest commit: 378f830 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This allows for better tracking of icon updates
…isspost/design-system into feat-initialize-icons-package
This was referenced Jan 17, 2023
|
Preview environment ready: https://preview-933--swisspost-design-system-styles.netlify.app |
gfellerph
requested review from
oliverschuerch and
alizedebray
as code owners
alizedebray
reviewed
Feb 6, 2023
oliverschuerch
requested changes
Feb 6, 2023
This was referenced Feb 7, 2023
This reverts commit ae0c66b.
alizedebray
approved these changes
Feb 7, 2023
oliverschuerch
approved these changes
Feb 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a script to download and transform icons from censhare. The script and tests are set up and icons can be downloaded using a proxy, but other things have to be implemented yet:
innerHTML={svg}and still be colorable