Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Enqueue recipes. #16

Merged
merged 9 commits into from
May 24, 2017
Merged

Add Enqueue recipes. #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae9a9f6
Enqueue recipes.
makasim May 8, 2017
3ad516f
fix env default value
makasim May 11, 2017
1e47192
remove gitignore rule for fs transport.
makasim May 11, 2017
f432413
remove post install text.
makasim May 11, 2017
0911f27
Address review comments.
makasim May 12, 2017
fbd9322
upd
makasim May 12, 2017
e1e0723
upd
makasim May 12, 2017
0fc35f2
upd
makasim May 13, 2017
95f1347
upd
makasim May 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions enqueue/amqp-ext/0.4/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"env": {
"ENQUEUE_DSN": "amqp://"
}
}
4 changes: 4 additions & 0 deletions enqueue/enqueue-bundle/0.4/etc/packages/enqueue.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
enqueue:
transport:
default: '%env(ENQUEUE_DSN)%'
client: ~
5 changes: 5 additions & 0 deletions enqueue/enqueue-bundle/0.4/etc/packages/test/enqueue.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
enqueue:
transport:
default: 'null://'
client:
traceable_producer: true
11 changes: 11 additions & 0 deletions enqueue/enqueue-bundle/0.4/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"bundles": {
"Enqueue\\Bundle\\EnqueueBundle": ["all"]
},
"copy-from-recipe": {
"etc/": "%ETC_DIR%/"
},
"env": {
"ENQUEUE_DSN": "null://"
}
}
5 changes: 5 additions & 0 deletions enqueue/fs/0.4/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"env": {
"ENQUEUE_DSN": "file:/%VAR_DIR%/enqueue"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the library take care to create the directory if it does not exist yet?

Copy link
Contributor Author

@makasim makasim May 17, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it does. https://github.com/php-enqueue/enqueue-dev/blob/master/pkg/fs/FsContext.php#L43

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use here file:// instead of file:/ ?

Copy link
Contributor

@Pierstoval Pierstoval May 24, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it a problem?
On Unix system, using file:// will result in paths like file:///var/www/dev/enqueue which might not work, whereas on windows it will result in file://e:/www/dev/enqueue which should work.

Dunno how to fix this 😱

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about Linux, but on macOS file:///var/www/dev/enqueue not only works, but it's the only way this can work: 3 / after file: is normal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok nevermind, I tested on my ubuntu distro and file:/// works, once again I should check before talking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened the issue. It'will be fixed.

}
}