Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document EventDispatcher changes #3879

Closed
2 tasks done
wouterj opened this issue May 26, 2014 · 5 comments
Closed
2 tasks done

Document EventDispatcher changes #3879

wouterj opened this issue May 26, 2014 · 5 comments
Milestone

Comments

@wouterj
Copy link
Member

wouterj commented May 26, 2014

  • The Debug\TraceableEventDispatcher should be documented in components/event_dispatcher (just like the other, already documented, dispatchers)
  • Document integration with DI component using the RegisterListenerPass (just a small section/sidebar in components/event_dispatcher/introduction)
@weaverryan
Copy link
Member

The first is done, we just need to tweak some namespaces for 2.5 with it (see #3916).

weaverryan added a commit that referenced this issue Jun 10, 2014
…eableEventDispatcher (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Component][EventDispatcher] documentation for the TraceableEventDispatcher

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3, 2.4
| Fixed tickets | #3879

After this has been merged, the document has to be updated for Symfony 2.5 and higher to reflect that the ``TraceableEventDispatcher`` is now part of the EventDispatcher component.

Commits
-------

1160f7c add documentation for the TraceableEventDispatcher class
weaverryan added a commit that referenced this issue Jun 11, 2014
…or the TraceableEventDispatcher (xabbuh)

This PR was merged into the 2.5 branch.

Discussion
----------

[Component][EventDispatcher] 2.5 specific documentation for the TraceableEventDispatcher

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.5+
| Fixed tickets | #3879

Commits
-------

cf667c9 update the TraceableEventDispatcher to reflect its movement to the EventDispatcher component in Symfony 2.5
@wouterj
Copy link
Member Author

wouterj commented Jun 11, 2014

Thanks @xabbuh for your quick actions on this one!

@wouterj wouterj closed this as completed Jun 11, 2014
@xabbuh
Copy link
Member

xabbuh commented Jun 11, 2014

@wouterj Can you reopen the issue? The second task isn't done yet.

@wouterj wouterj reopened this Jun 11, 2014
@wouterj
Copy link
Member Author

wouterj commented Jun 11, 2014

Oh, indeed. Sorry about that, ryan said everything was fixed after your last PR, but he only meant the first item :)

@xabbuh
Copy link
Member

xabbuh commented Jun 11, 2014

Never mind. :) I think we can get it fixed at the next weekend.

weaverryan added a commit that referenced this issue Aug 16, 2014
… RegisterListenersPass (xabbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Components][EventDispatcher] describe the usage of the RegisterListenersPass

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #3879

Commits
-------

36407e0 describe the usage of the RegisterListenersPass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants