[Components][Routing] Fix addPrefix() sample code #3622
Conversation
| ->addOptions(array(...)) | ||
| ->setHost('admin.example.com') | ||
| ->setMethods(array('POST')) | ||
| ->setSchemes(array('https')); |
There was a problem hiding this comment.
You're absolutely right about the wrong arguments to addPrefix, but I don't think the methods can be chained like this - it looks like they all return null: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/RouteCollection.php#L149
|
@weaverryan Oh, thanks for verifying this fix, can't remember how that fluid usage slipped in... ;-) But I've found another issue: The versionadded note below the |
|
I agree and like how you handled it :). Thanks as always Philipp |
This PR was merged into the 2.3 branch. Discussion ---------- [Components][Routing] Fix addPrefix() sample code | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - The sample code used for demonstrating the [`Symfony\Component\Routing\RouteCollection::addPrefix()`](http://api.symfony.com/2.3/Symfony/Component/Routing/RouteCollection.html#method_addPrefix) method did not match the signature. I've updated the code to show the provided features when adding a nested route collection. + some minor fixes along the way. Commits ------- e095c13 [Components][Routing] Fix addPrefix() sample code
The sample code used for demonstrating the
Symfony\Component\Routing\RouteCollection::addPrefix()method did not match the signature. I've updated the code to show the provided features when adding a nested route collection. + some minor fixes along the way.