DQL custom functions on doctrine reference page #3946
Conversation
Seems that there is two possibilities to configure custom DQL functions It should be clearified in doctrine reference page because It may confuse some people if they just read the cookbook: http://symfony.com/doc/current/cookbook/doctrine/custom_dql_functions.html
|
This applies to all settings for entity managers, can you please make it a bit more generic. Btw, I love your work :) It's just a minor thing |
|
Sure, as soon as I am back at home. Thanks! |
Changed documentation to explain shorten syntax in general, not just DQL functions part
|
I think it's quite clear now, let me know your opinion about it. Thanks! |
| orm: | ||
| # ... | ||
| query_cache_driver: | ||
| type: array # Required |
There was a problem hiding this comment.
I think - to avoid duplication (but to keep things clear) we should only show the top-level items (e.g. query_cache_driver, metadata_cache_driver, etc) and put a #... under each if it has child options. So:
query_cache_driver:
# ...
metadata_cache_driver:
# ...
result_cache_driver:
# ...
connection: ~
class_metadata_factory_name: Doctrine\ORM\Mapping\ClassMetadataFactoryand then continued for everything else. What do you think about that?
There was a problem hiding this comment.
Probably it will be easier to understand, yes. The shorter, the better in this case.
Made more clear the shorten doctrine.yml syntax, leaving only the first level of configuration.
| @@ -411,3 +411,37 @@ Each connection is also accessible via the ``doctrine.dbal.[name]_connection`` | |||
| service where ``[name]`` is the name of the connection. | |||
|
|
|||
| .. _DBAL documentation: http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html | |||
|
|
|||
| Shorten configuration syntax | |||
Proposed changes to format
| filters: | ||
| # ... | ||
|
|
||
| This shorten version is commonly used in other documentation sections. |
|
@healdropper There are just a few very minor things left! If you can make those updates, I'll merge! |
Minor typos changes
More typos oops :P
Fix for "Title underline too short"
|
@weaverryan There you go! Thanks! |
| @@ -411,3 +411,39 @@ Each connection is also accessible via the ``doctrine.dbal.[name]_connection`` | |||
| service where ``[name]`` is the name of the connection. | |||
|
|
|||
| .. _DBAL documentation: http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/configuration.html | |||
|
|
|||
| Shortened Configuration syntax | |||
There was a problem hiding this comment.
Syntax should use an uppercased S
Included more suggestions
|
Thanks @healdropper for your hard work. I think this is a great new note! Cheers! |
Custom DQL functions can be configured in two ways, according to what I was told here
It should be clearified in doctrine reference page because It may confuse some people that just read the cookbook section about custom DQL functions