Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inherit_data_option.rst #4066

Closed
wants to merge 2 commits into from
Closed

Update inherit_data_option.rst #4066

wants to merge 2 commits into from

Conversation

Oylex
Copy link
Contributor

@Oylex Oylex commented Jul 29, 2014

No description provided.

@@ -154,3 +154,7 @@ Finally, make this work by adding the location form to your two original forms::

That's it! You have extracted duplicated field definitions to a separate
location form that you can reuse wherever you need it.

.. note::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a caution directive does make more sense.

@wouterj
Copy link
Member

wouterj commented Jul 30, 2014

Looks good! 👍 for me.
@weaverryan will merge it in 2.3 when he has some time.
Thank you for contributing this usefull information to the docs! I'm sure it'll save debugging time for developers.

@weaverryan
Copy link
Member

Great note indeed! Thanks Joel!

@weaverryan weaverryan closed this in e5d5eb8 Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants