[Best Practices] update best practices index #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can also simply add |
|
That should probably do the same. But this is the way we have it in the other parts of the documentation. And I think it's easier to understand for newcomers of we keep it consistent. |
|
@wouterj @weaverryan What do you think? |
| @@ -14,3 +15,5 @@ Official Symfony Best Practices | |||
| security | |||
| web-assets | |||
| tests | |||
|
|
|||
| .. include:: map.rst.inc | |||
There was a problem hiding this comment.
Everywhere else, this path is absolute. I'm not sure if it'll matter, but we might as well be absolute here too to avoid issues.
This way, the table of contents on the index page has only one level like every other index in the documentation.
xabbuh
force-pushed
the
best-practices-index
branch
from
7893658 to
facea46
Compare
|
Thanks Christian! |
weaverryan
added a commit
that referenced
this pull request
Nov 10, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Best Practices] update best practices index | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | This way, the table of contents on the index page has only one level like every other index in the documentation. Commits ------- facea46 update best practices index
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the table of contents on the index page has only one level
like every other index in the documentation.