Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3412 correct overridden option name of timezone #5124

Closed
wants to merge 3 commits into from
Closed

#3412 correct overridden option name of timezone #5124

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5354c35
#3412 correct overriden option's name of timezone
oleksandr-kaleniuk Mar 30, 2015
81d018f
fix table
oleksandr-kaleniuk Mar 31, 2015
7269707
change length of underlining characters
oleksandr-kaleniuk Mar 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions reference/forms/types/timezone.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ you should just use the ``choice`` type directly.
+-------------+------------------------------------------------------------------------+
| Rendered as | can be various tags (see :ref:`forms-reference-choice-tags`) |
+-------------+------------------------------------------------------------------------+
| Overridden | - `choice_list`_ |
| Overridden | - `choices`_ |
| Options | |
+-------------+------------------------------------------------------------------------+
| Inherited | from the :doc:`choice </reference/forms/types/choice>` type |
Expand Down Expand Up @@ -49,12 +49,12 @@ you should just use the ``choice`` type directly.
Overridden Options
------------------

choice_list
choices
~~~~~~~~~~~
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very minor comment: in the documentation we always make the below underlining characters match the length of the above heading:

choices
~~~~~~~


**default**: :class:`Symfony\\Component\\Form\\Extension\\Core\\ChoiceList\\TimezoneChoiceList`

The Timezone type defaults the choice_list to all timezones returned by
The Timezone type defaults the choices to all timezones returned by
:phpmethod:`DateTimeZone::listIdentifiers`, broken down by continent.

Inherited Options
Expand Down