Point that route parameters are also Request attributes

[sfdumi]

Point that route parameters are also Request attributes

[javiereguiluz]

@sfdumi 👍 I like your proposal because a lot of people are not aware of this. Thank you!

[OskarStark]

$titleAttribute is confusing imo, to show this, its enough to write $request->attributes->get('title'); // same as $title

what do you thing @javiereguiluz

[javiereguiluz]

I agree with you. We could even split the example in two parts:

// Getting the title via controller arguments

public function indexAction($page, $title)
{
    // ...
}

// Getting the title via request attributes

use Symfony\Component\HttpFoundation\Request;

public function indexAction(Request $request)
{
    $title = $request->attributes->get('title');
    // ...
}

[sfdumi]

This sounds like a good idea. Should I update the PR?

[xabbuh]

We change this a bit and only tell the reader that we can access the parameters in the controller:

[...] that will then be accessible in your controller::

[wouterj]

I like this addition! If you can and agree with them, please update this PR to add the proposed changes.

[sfdumi]

Updated the PR.

[javiereguiluz]

👍 this PR looks ready to be merged. Our doc managers can fix some long lines when merging this.

Thanks @sfdumi.

[wouterj]

👍 (I'm very sorry, the update comment completely slipped under my radar)

[xabbuh]

Thank you for these improvements @sfdumi! I have merged them into the 2.3 branch.