Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process: callbacks now allowed when output disabled #6648

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Process: callbacks now allowed when output disabled #6648

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions components/process.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,9 +302,14 @@ Use :method:`Symfony\\Component\\Process\\Process::disableOutput` and
You can not enable or disable the output while the process is running.

If you disable the output, you cannot access ``getOutput``,
``getIncrementalOutput``, ``getErrorOutput`` or ``getIncrementalErrorOutput``.
Moreover, you could not pass a callback to the ``start``, ``run`` or ``mustRun``
methods or use ``setIdleTimeout``.
``getIncrementalOutput``, ``getErrorOutput``, ``getIncrementalErrorOutput`` or
``setIdleTimeout``.

However, it is possible to pass a callback to the ``start``, ``run`` or ``mustRun``
methods to handle process output in a streaming fashion.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a little versionadded block below this?

.. versionadded:: 3.1
    The ability to pass a callback to these methods when output is disabled was added in Symfony 3.1.

Thanks!


.. versionadded:: 3.1
The ability to pass a callback to these methods when output is disabled was added in Symfony 3.1.

.. _`Symfony Issue#5759`: https://github.com/symfony/symfony/issues/5759
.. _`PHP Bug#39992`: https://bugs.php.net/bug.php?id=39992
Expand Down