Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caution about impersonation not compatible with pre authenticated #6673

Merged
merged 2 commits into from
Jul 2, 2016
Merged

Caution about impersonation not compatible with pre authenticated #6673

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4249f3
improve caution about impersonation not compatible with pre authentic…
pasdeloup Jun 22, 2016
b5354e5
fix pre Authenticated -> pre-authenticated
pasdeloup Jun 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions cookbook/security/impersonating_user.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,17 @@ How to Impersonate a User

Sometimes, it's useful to be able to switch from one user to another without
having to log out and log in again (for instance when you are debugging or trying
to understand a bug a user sees that you can't reproduce). This can be easily
done by activating the ``switch_user`` firewall listener:
to understand a bug a user sees that you can't reproduce).

.. caution::

User impersonation is not compatible with
:doc:`pre Authenticated firewalls</cookbook/security/pre_authenticated>`. The
reason is that impersonation requires the authentication state to be maintained
server-side but pre Authenticated information (``SSL_CLIENT_S_DN_Email``,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre Authenticated information -> preauthenticated information or pre-authenticated information

``REMOTE_USER`` or other) is sent in each request.

This can be easily done by activating the ``switch_user`` firewall listener:

.. configuration-block::

Expand Down
14 changes: 8 additions & 6 deletions cookbook/security/pre_authenticated.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ box, Symfony supports most authentication mechanisms.
These requests are called *pre authenticated* requests because the user is already
authenticated when reaching your application.

.. caution::

:doc:`User impersonation </cookbook/security/impersonating_user>` is not
compatible with pre Authenticated firewalls. The reason is that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre Authenticated firewalls -> preauthenticated firewalls or pre-authenticated firewalls

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what I would write also, but the title of the cookbook is "Using pre Authenticated Security Firewalls" so I wanted to be consistent.
https://symfony.com/doc/2.7/cookbook/security/pre_authenticated.html

Should it be changed everywhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasdeloup the reason is that we use a strange format for titles, but for regular text we don't mix upper and lower case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fixed. I missed that rule about section titles
However, shouldn't the title be either

Using pre-Authenticated Security Firewalls

or

Using Preauthenticated Security Firewalls

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasdeloup it's "complicated" to say if you are right or wrong. First, the title casing is arbitrary and some words are uppercased and others aren't. Moreover, the hyphen after prefixes is also arbitrary in some cases, so I don't know if it's written "preauth..." or "pre-auth..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's keep like that for now ;)

impersonation requires the authentication state to be maintained server-side
but pre Authenticated information (``SSL_CLIENT_S_DN_Email``, ``REMOTE_USER``
or other) is sent in each request.

X.509 Client Certificate Authentication
---------------------------------------

Expand Down Expand Up @@ -152,9 +160,3 @@ key in the ``remote_user`` firewall configuration.
See :ref:`the previous note <cookbook-security-pre-authenticated-user-provider-note>`
for more information.

.. caution::

:doc:`User impersonation </cookbook/security/impersonating_user>` is not
compatible with ``REMOTE_USER`` based authentication. The reason is that
impersonation requires the authentication state to be maintained server-side
but ``REMOTE_USER`` information is sent by the browser in each request.