Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckStyle in Voters cookbook #6674

Closed
wants to merge 2 commits into from
Closed

CheckStyle in Voters cookbook #6674

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59b1e41
Update voters.rst
JakeFr Jun 22, 2016
c515abf
Update voters.rst
JakeFr Jun 22, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cookbook/security/voters.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,10 @@ would look like this::
}

// you know $subject is a Post object, thanks to supports
/** @var Post $post */
/* @var Post $post */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change has to be reverted. Seems like a bug in PHP CS Fixer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change made by phpdoc_to_comment fixer (Symfony level)
Docblocks should only be used on structural elements.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that rule isn't used by Symfony. Please disable that fixer :)

$post = $subject;

switch($attribute) {
switch ($attribute) {
case self::VIEW:
return $this->canView($post, $user);
case self::EDIT:
Expand Down