[CS] Avoid using useless expressions #6701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -175,6 +175,9 @@ Structure | |||
| switched to opt-in via ``@`` operator. | |||
| Read more at :ref:`contributing-code-conventions-deprecations`. | |||
|
|
|||
| * Do not use ``else``, ``elseif``, ``break`` after ``if`` and ``case`` conditions | |||
| which returns or throws something. | |||
There was a problem hiding this comment.
I'm not sure, but should we say ... which return or throw something instead of ... which returnS or throwS something ?
There was a problem hiding this comment.
I agree @javiereguiluz since we are talking about them plural, and not separately. I'll update this ASAP. Thank you.
|
👍 |
| Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | all | Fixed tickets | N/A Do not use `else`, `elseif`, `break` after `if` and `case` conditions which return or throw something.
phansys
force-pushed
the
cs_avoid_useless_expressions
branch
from
6a64cd5 to
d96faa4
Compare
|
Thanks Javier! |
wouterj
added a commit
that referenced
this pull request
Jul 8, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [CS] Avoid using useless expressions | Q | A | ------------- | --- | Doc fix? | yes | New docs? | yes | Applies to | all | Fixed tickets | N/A Do not use `else`, `elseif`, `break` after `if` and `case` conditions which returns or throws something. Commits ------- d96faa4 Avoid using useless expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use
else,elseif,breakafterifandcaseconditionswhich returns or throws something.