Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Book] Remove DI extension info and link the cookbook article instead #6715

Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 5, 2016

Imo, information about how to make your shared bundle load services doesn't belong in the book. I've replaced it with a shorter description and a link to the cookbook articles instead.

in the FrameworkBundle, is invoked and the service configuration for the
FrameworkBundle is loaded.

The settings under the ``framework`` directive (e.g. ``form: true``) indicates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indicate

@javiereguiluz
Copy link
Member

👍

Status: reviewed

We definitely need more rewordings like this to simplify the book and move advanced contents to cookbooks. Wouter, thanks a lot for working on this.

@wouterj wouterj force-pushed the book/service_container-remove-extension branch from b8c8ced to 183e8be Compare July 8, 2016 09:32
@weaverryan
Copy link
Member

HUGE win :D

@weaverryan weaverryan merged commit 183e8be into symfony:2.7 Jul 10, 2016
weaverryan added a commit that referenced this pull request Jul 10, 2016
…icle instead (WouterJ)

This PR was merged into the 2.7 branch.

Discussion
----------

[Book] Remove DI extension info and link the cookbook article instead

Imo, information about how to make your shared bundle load services doesn't belong in the book. I've replaced it with a shorter description and a link to the cookbook articles instead.

Commits
-------

183e8be Remove complex DI extension information and link the cookbook article instead
@wouterj wouterj deleted the book/service_container-remove-extension branch July 10, 2016 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants