New approach for checking we are loading the right file #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subsumes #60.
Here's an approach for feedback, I pulled the logic up into the xml_open class because otherwise I'd need to pass the root tag all the way down through the helper functions and it made the try-with-if-raise nesting complex in
find_file_in_zip
.I want to clean up a bit more of that logic, but this is a good start for feedback