Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New approach for checking we are loading the right file #62

Merged
merged 3 commits into from
Jul 27, 2016
Merged

New approach for checking we are loading the right file #62

merged 3 commits into from
Jul 27, 2016

Conversation

t8y8
Copy link
Contributor

@t8y8 t8y8 commented Jul 26, 2016

This subsumes #60.

Here's an approach for feedback, I pulled the logic up into the xml_open class because otherwise I'd need to pass the root tag all the way down through the helper functions and it made the try-with-if-raise nesting complex in find_file_in_zip.

I want to clean up a bit more of that logic, but this is a good start for feedback

@t8y8 t8y8 mentioned this pull request Jul 26, 2016
@graysonarts
Copy link
Contributor

🚀

@t8y8 t8y8 merged commit 4d6ff51 into tableau:development Jul 27, 2016
@t8y8 t8y8 deleted the bugfix-60-xml-open branch July 27, 2016 10:57
@graysonarts graysonarts modified the milestone: 2016.08 release Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants