Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test to verify #80 #83

Merged
merged 9 commits into from
Sep 19, 2016
Merged

Add a test to verify #80 #83

merged 9 commits into from
Sep 19, 2016

Conversation

graysonarts
Copy link
Contributor

This is picking up weird commits because of merging issues, but only the last commit is important.

Russell Hay and others added 8 commits June 29, 2016 09:56
Updating README to include information for installing from pip
CLANotRequired
* Scrub some strings in the test file so they don't include internal references
* Updated some of the assets to be consistent in casing
Copy link
Contributor

@t8y8 t8y8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though the PR has a bunch of other commits in it -- I trust you can fix that :)

Also for some reason pep8 is failing on one of the samples, is that related to this?

@graysonarts
Copy link
Contributor Author

@t8y8 weird. I have pep8 running in my pre-commit hook, I don't know why it even let me check in. I'll get that fixed and merged. The other commits are a non-issue and already exist in development. It's just a weirdness with the squashing, etc. I'm starting to think we should maybe stop squashing on merge.

@t8y8
Copy link
Contributor

t8y8 commented Sep 19, 2016

🚀

@graysonarts graysonarts merged commit 01f232f into tableau:development Sep 19, 2016
@graysonarts graysonarts deleted the test-80-bugfix branch September 19, 2016 17:14
graysonarts pushed a commit that referenced this pull request Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants