Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show suggestions for fractions in IntelliSense #16353

Merged
merged 6 commits into from
Feb 11, 2025

Conversation

thecrypticace
Copy link
Contributor

@thecrypticace thecrypticace commented Feb 7, 2025

Fixes tailwindlabs/tailwindcss-intellisense#1178 (partially)

An IntelliSense PR (+ Play update) is required to make this work better with v4: tailwindlabs/tailwindcss-intellisense#1182

Screenshot 2025-02-07 at 15 19 59

@thecrypticace thecrypticace marked this pull request as ready for review February 7, 2025 20:46
@thecrypticace thecrypticace requested a review from a team as a code owner February 7, 2025 20:46
@thecrypticace thecrypticace force-pushed the fix/v4-fraction-suggestions branch from 3b12c0d to 3d5e295 Compare February 10, 2025 21:58
@thecrypticace thecrypticace changed the base branch from main to fix/v4-compare-fn February 10, 2025 21:58
@thecrypticace thecrypticace force-pushed the fix/v4-fraction-suggestions branch from 3d5e295 to 538b0d2 Compare February 10, 2025 22:05
Base automatically changed from fix/v4-compare-fn to main February 10, 2025 22:08
@thecrypticace thecrypticace force-pushed the fix/v4-fraction-suggestions branch from 538b0d2 to fcf6505 Compare February 10, 2025 22:09
@thecrypticace thecrypticace force-pushed the fix/v4-fraction-suggestions branch from 02469cd to 711b50d Compare February 11, 2025 12:32
@thecrypticace thecrypticace merged commit aad440e into main Feb 11, 2025
5 checks passed
@thecrypticace thecrypticace deleted the fix/v4-fraction-suggestions branch February 11, 2025 17:03
@alexchexes
Copy link

alexchexes commented Feb 12, 2025

Is it intentional that there are fractions like 2/4 (which equals 1/2), 2/6, 3/6, etc.? Full list:

image

'9/12',
'10/12',
'11/12',
]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional that there are fractions like 2/4 (which equals 1/2), 2/6, 3/6, etc.? Full list:

image

@thecrypticace
Copy link
Contributor Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 - broken 1/2 completions
3 participants