Fix sorting numeric utilities when they have different magnitudes #16414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
thecrypticace
force-pushed
the
fix/v4-compare-fn
branch
from
0854481 to
2bf7ed8
Compare
peterpeterparker
added a commit
to dfinity/oisy-wallet
that referenced
this pull request
Feb 18, 2025
# Motivation We detected reproducibility issue when building v0.24.0: https://github.com/dfinity/oisy-wallet/actions/runs/13393064153 ~~I'm unsure which of the two following Tailwind fix was the reason of the problem but, bumping Tailwind to latest version seems to resolve the problem.~~ ~~Tailwind v4.0.6 - Fix [#16403](tailwindlabs/tailwindcss#16403 ~~- Revert change to no longer include theme variables that aren't used in compiled CSS ~~ ~~Tailwind v4.0.7 - Fix [#16414](tailwindlabs/tailwindcss#16414 ~~- Fix sorting of numeric utility suggestions when they have different magnitudes~~ ~~I lean towards to former though. I could have try v4.0.6 but, v4.0.7 contains interesting fixes anyway.~~ It does not resolve the issue: https://github.com/dfinity/oisy-wallet/actions/runs/13395505962/job/37413394328 # Changes - Bump `@tailwindcss/postcss`, `@tailwindcss/vite` and `tailwindcss`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sorting utilities it was possible for a utility like
duration-700to come beforeduration-75orduration-1000to come beforeduration-150.This PR fixes this behavior by reading the full "magnitude" of each numbers before we compare them.