Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit --tw-drop-shadow property #16471

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Emit --tw-drop-shadow property #16471

merged 3 commits into from
Feb 12, 2025

Conversation

philipp-spiess
Copy link
Member

Fixes #16461

Ensure we also emit @property --tw-drop-shadow.

Test plan

<div class="drop-shadow-2xl size-72 bg-white">
  <div class="size-48 saturate-100 bg-white"></div>
</div>

now only drops one shadow (screenshot from Vite playground):

Screenshot 2025-02-12 at 16 37 25

@philipp-spiess philipp-spiess requested a review from a team as a code owner February 12, 2025 15:38
@thecrypticace
Copy link
Contributor

We should add a UI test for this if we can

@philipp-spiess philipp-spiess force-pushed the fix/emit-drop-shadow-property branch from 8efc0ad to 7ca2833 Compare February 12, 2025 17:28
@philipp-spiess philipp-spiess merged commit 6164783 into main Feb 12, 2025
5 checks passed
@philipp-spiess philipp-spiess deleted the fix/emit-drop-shadow-property branch February 12, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecrypticace thecrypticace thecrypticace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing @property for --tw-drop-shadow
2 participants
@philipp-spiess @thecrypticace