Fix Slim attributes #16985
Merged
Fix Slim attributes #16985
+131
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g.:
```slim
.text-xl.text-red-600[
^ This is not part of the candidate
data-foo="bar"
]
| This line should be red
```
philipp-spiess
approved these changes
Mar 6, 2025
|
Wow! I used to throw a, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in Slim templates where the start of attributes causes some candidates to be missing.
Because of the
[attached to thetext-red-600, thetext-red-600was not extracted because[is not a valid boundary character.To solve this, we copied the Pug pre processor and created a dedicated Slim pre processor. Next, we ensure that we replace
[with[where it's important).Additionally, we noticed that
.was also replaced inside of arbitrary values such as URLs. This has been fixed for both Pug and Slim.Fixes: #16975
Test plan