Introduce ZINNIA_STATIC_LIBRARY for Windows #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ZINNIA_DLL_EXTERN macro defined in zinnia.h can only be either __declspec(dllexport) or __declspec(dllimport), which results in a compile error for projects that want to use Zinnia as a static library. With this CL, we can specify ZINNIA_STATIC_LIBRARY to build and use Zinnia as a static library on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ZINNIA_DLL_EXTERNmacro defined in zinnia.h can only be either__declspec(dllexport)or__declspec(dllimport), which results in a compile error for projects that want to use Zinnia as a static library.With this CL, we can specify
ZINNIA_STATIC_LIBRARYto build and use Zinnia as a static library on Windows.