Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the native token symbol be hardcoded instead of dynamic to improve performance #2257

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

vutuanlinh2k2
Copy link
Contributor

Summary of changes

Provide a detailed description of proposed changes.

  • Have the token unit be hardcoded instead of dynamic
  • Add new Tangle constants for universal use
  • Remove EVM Explorer URL for local Tangle

Proposed area of change

Put an x in the boxes that apply.

  • apps/bridge-dapp
  • apps/hubble-stats
  • apps/stats-dapp
  • apps/tangle-dapp
  • apps/testnet-leaderboard
  • apps/faucet
  • apps/zk-explorer
  • libs/webb-ui-components

Reference issue to close (if applicable)

Specify any issues that can be closed from these changes (e.g. Closes #233).


Code Checklist

Please be sure to add .stories documentation if any additions are made to libs/webb-ui-components.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 3c00f69
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/662706f729081e000864aa36
😎 Deploy Preview https://deploy-preview-2257--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for testnet-leaderboard ready!

Name Link
🔨 Latest commit 3c00f69
🔍 Latest deploy log https://app.netlify.com/sites/testnet-leaderboard/deploys/662706f7d4a86700084bab64
😎 Deploy Preview https://deploy-preview-2257--testnet-leaderboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for hubble-stats ready!

Name Link
🔨 Latest commit 3c00f69
🔍 Latest deploy log https://app.netlify.com/sites/hubble-stats/deploys/662706f727715700083be444
😎 Deploy Preview https://deploy-preview-2257--hubble-stats.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for zkexplorer ready!

Name Link
🔨 Latest commit 3c00f69
🔍 Latest deploy log https://app.netlify.com/sites/zkexplorer/deploys/662706f7e7ed200008a44dfc
😎 Deploy Preview https://deploy-preview-2257--zkexplorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need to fix CI

@vutuanlinh2k2 vutuanlinh2k2 merged commit 5c6f377 into develop Apr 23, 2024
23 checks passed
@vutuanlinh2k2 vutuanlinh2k2 deleted the linh/hardcode-native-token-symbol branch April 23, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Have the token unit be hardcoded instead of dynamic
2 participants