Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tangle-dapp): Show LST icons from pool metadata, if set #2653

Merged
merged 36 commits into from
Nov 29, 2024

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Nov 13, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • ➕ LST icons are now loaded if they're present in LS pools metadata and shown everywhere the LST's icon appears.
  • ➕ Created formatDisplayAmount utility function to standardize balance formatting for UIs.
  • 🔧 Adjusted the precision of some of the balances shown across tables, such as reducing precision for TVLs to reduce the space taken in the case of very small amounts.
  • 🐛 Added missing decimals prop to some token amount table cells that were missing it, which was causing precision problems.
  • 🐛 Fixed a bug when claiming a lot of payouts, now it limits it to 40 to avoid exceeing the block weight limit. This means that the Payout All button will have to be used multiple times if there are more than 40 pending payouts.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.
Screenshot 2024-11-13 at 23 17 49

Screenshot 2024-11-15 at 01 23 18

@yurixander yurixander self-assigned this Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 1c9bb75
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/674a119c0080ff0008ff194f
😎 Deploy Preview https://deploy-preview-2653--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 1c9bb75
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/674a119c43568e0008bb7644
😎 Deploy Preview https://deploy-preview-2653--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yurixander yurixander changed the title feat(tangle-dapp): Show LST icons from pool metadata (if set) feat(tangle-dapp): Show LST icons from pool metadata, if set Nov 25, 2024
@yurixander
Copy link
Member Author

@AtelyPham Getting an error after updating Substrate types package:
Screenshot 2024-11-25 at 22 15 20

Also, I made two updates to the apps/tangle-dapp/data/restake/RestakeTx/substrate.ts file since the update of the types added a new parameter. Let me know if those are the right parameters 👀 .
Screenshot 2024-11-25 at 22 16 13

@yurixander yurixander marked this pull request as ready for review November 29, 2024 18:23
@yurixander yurixander marked this pull request as draft November 29, 2024 19:08
@yurixander yurixander marked this pull request as ready for review November 29, 2024 19:16
@drewstone drewstone merged commit 56abc20 into develop Nov 29, 2024
15 checks passed
@drewstone drewstone deleted the yuri/add-ls-pools-icon branch November 29, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed ✅
2 participants