Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tangle-dapp): Improve Error Handling When Parsing Response #2757

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

AtelyPham
Copy link
Member

@AtelyPham AtelyPham commented Jan 26, 2025

Summary of changes

Provide a detailed description of proposed changes.

  • Add an option to disable error notifications for the KeyStatsItem component.
  • Do not throw an error when fetching rewards.
  • Avoid retrying on errors when fetching rewards.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Copy link

netlify bot commented Jan 26, 2025

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 2f8ec0b
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/6795e3bba1e81f000904ae8c
😎 Deploy Preview https://deploy-preview-2757--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 26, 2025

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 2f8ec0b
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/6795e3bb8a17510008bd0a7a
😎 Deploy Preview https://deploy-preview-2757--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably make a helper function for this to reduce LOC, looks good

@AtelyPham AtelyPham merged commit 2f42856 into develop Jan 26, 2025
17 checks passed
@AtelyPham AtelyPham deleted the trung-tin/fix-zod-parser-error branch January 26, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed ✅
Development

Successfully merging this pull request may close these issues.

3 participants