Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tangle-dapp): Various bug fixes #2796

Merged
merged 13 commits into from
Feb 14, 2025
Merged

fix(tangle-dapp): Various bug fixes #2796

merged 13 commits into from
Feb 14, 2025

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Feb 6, 2025

Summary of changes

Provide a detailed description of proposed changes.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

Screenshot 2025-02-11 at 22 45 38
Screenshot 2025-02-11 at 22 46 17
Screenshot 2025-02-11 at 22 46 43
Screenshot 2025-02-11 at 22 47 08

@yurixander yurixander self-assigned this Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for tangle-dapp ready!

Name Link
🔨 Latest commit 7cef9cd
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/67afa90545f3820008dec8fa
😎 Deploy Preview https://deploy-preview-2796--tangle-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for tangle-cloud ready!

Name Link
🔨 Latest commit 7cef9cd
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/67afa9054e459d0008b6aa88
😎 Deploy Preview https://deploy-preview-2796--tangle-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yurixander yurixander changed the title feat(tangle-dapp): Unify transaction tracking into a drawer fix(tangle-dapp): Various bug fixes Feb 7, 2025
@yurixander
Copy link
Member Author

Status for this PR: Waiting on the batch precompile bug reproduction to determine if it is a Tangle node bug or a frontend/dapp problem. All the other issues in this PR have been addressed.

@drewstone drewstone marked this pull request as ready for review February 13, 2025 16:09
Copy link
Contributor

@monaiuu monaiuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • while we're at it, can we fix inconsistent address formats:
Screenshot 2025-02-14 at 12 42 25 AM

Copy link
Member

@AtelyPham AtelyPham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@yurixander yurixander merged commit 4b41af1 into develop Feb 14, 2025
16 checks passed
@yurixander yurixander deleted the yuri/misc-changes branch February 14, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed ✅
3 participants